Shelter stable dates from USE_TZ #3048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dates (publication dates, author dates) are meant as _literals_. What the user inputs through a `SelectDateWidget` should be preserved as-is. Django's otherwise-excelent support for timezones interferes with it (see Until a better fate of these columns is determined (do we migrate them to a DateField?), and as a stop-gap measure, we can start being faithful to the data by storing them in the Eastern-most timezone. This is particularly important because 1/1/YYYY is a common pattern in publication dates, given bookwyrm-social#743.
dato
force-pushed
the
stable_dates_v0
branch
2 times, most recently
from
de44d4b to
0a39ec3
Compare
|
Dropping in favor of #3059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dates (publication dates, author dates) are meant as literals. What
the user inputs through a
SelectDateWidgetshould be preserved as-is.Django's otherwise-excelent support for timezones interferes with it (see
#3028).
Until a better fate of these columns is determined (do we migrate them to a
DateField?), and as a stop-gap measure, we can start being faithful to the
data by storing them in the Western-most timezone.
This is particularly important because
1/1/YYYYis a common pattern inpublication dates, given #743.
Fixes: #3028.
#3028 is somewhat intertwined with #743, because both work with the same columns. In general, I try to structure work in chunks that do something small and can be meaningfully applied.
With no need for a migration, I think this is a net win wrt the "shifting year" issue that was recently reported.
Furthermore, I believe in the future we might be able to deduce the correct tz conversions to apply. With this PR, I just offer a small tuning to affect/fix observable behavior.
Many thanks in advance for any reviews!