Federate reports #3188
Open
Federate reports #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is such an annoying change but it is objectively better. Just gotta be real sure they didn't get mixed up anywhere along the way.
Shows a checkbox for the user and lets the admin know
mouse-reeve
force-pushed
the
federate-reports
branch
from
94409e4 to
8de3668
Compare
I'm writing this offline so I can't check what the actual Flag activity spec looks like from Mastodon.
…m into federate-reports
This allows us to support mastodon reports that include multiple statuses
hughrun
reviewed
Nov 30, 2024
| def object(self): | ||
| """Generate a list of reported objects in a format Mastodon will like""" | ||
| items = [self.reported_user.remote_id] | ||
| if self.statuses: |
There was a problem hiding this comment.
When I test this self.statuses is always bookwyrm.Status.None here. So the status is never sent to Mastodon. However statuses obviously isn't empty because in the BookWyrm admin interface I can see it. So I have no idea what is going on but it's weird and means statuses aren't passed through to federated servers with the report.
| blank=True, | ||
| activitypub_field="to", | ||
| ) | ||
| statuses = models.ManyToManyField( | ||
| "Status", | ||
| null=True, |
There was a problem hiding this comment.
No need to set null on a ManyToManyField.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports should be sent (if the user wants) to the home instance for remote users. I'm using mastodon's Flag activity as a template: https://docs.joinmastodon.org/spec/activitypub/#Flag
Fixes #962
Components:
usermeans the user doing the reporting, not the reported user