Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide ratings #3418

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Hide ratings #3418

merged 5 commits into from
Aug 27, 2024

Conversation

mouse-reeve
Copy link
Member

@mouse-reeve mouse-reeve commented Aug 24, 2024

Description

Allow users who don't want to see the star rating of a book to have them hidden by default in the UI. Instead of the rating, a button that can be clicked to reveal the rating is shown.

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them
Screenshot 2024-08-23 at 5 37 42 PM Screenshot 2024-08-23 at 5 37 38 PM

@mouse-reeve
Copy link
Member Author

mouse-reeve commented Aug 24, 2024

@bookwyrm-social/code-review 👁️ (the one test failure seems to be unrelated)

@hughrun
Copy link
Contributor

hughrun commented Aug 27, 2024

Looks good to me!

@hughrun hughrun merged commit 23dfe39 into main Aug 27, 2024
10 checks passed
@mouse-reeve mouse-reeve deleted the hide-ratings branch August 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to hide ratings
2 participants