Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Work around unplugin bug #2226

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

dwgray
Copy link
Contributor

@dwgray dwgray commented Sep 23, 2024

Describe the PR

It looks like unplugin-vue-components has a bug where it doesn't correctly handle <script setup='ts'> in vitepress (possibly in SSR mode in general). I will continue to refine unplugin/unplugin-vue-components#801 and see if I can get an upstream fix, but this workaround gets us up and running again.

All the docs that were depending on unplugin-vue-component now use <script> rather than <script setup> sections. Since all we're doing in these files is importing data for the component reference, this still seems like a big win over not using unplugin-vue-component.

I also started getting a circular reference error when using the tooltip composable, so I converted to the component.

Small replication

Look at the breadcrumb or carousel documentation under app\docs after doing a pnpm build followed by pnpm preview

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Copy link

stackblitz bot commented Sep 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

pkg-pr-new bot commented Sep 23, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2226
pnpm add https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2226

commit: f3d4c9b

@dwgray dwgray marked this pull request as ready for review September 23, 2024 19:58
@VividLemon VividLemon merged commit 70bea39 into bootstrap-vue-next:main Sep 29, 2024
4 checks passed
@dwgray dwgray deleted the workaround-unplugin branch September 29, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants