Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): add linting and formatting to CI #3816

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore(lint): add linting and formatting to CI #3816

wants to merge 3 commits into from

Conversation

greg-in-a-box
Copy link
Contributor

No description provided.

@greg-in-a-box greg-in-a-box changed the title New prettier ci chore(lint-staged): added lint-staged to yarn lint Dec 20, 2024
@greg-in-a-box greg-in-a-box force-pushed the new-prettier-ci branch 2 times, most recently from a53a2f2 to 9a7b4a3 Compare January 6, 2025 20:49
@greg-in-a-box greg-in-a-box changed the title chore(lint-staged): added lint-staged to yarn lint chore(lint): add linting and formatting to CI Jan 6, 2025
tjuanitas
tjuanitas reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@tjuanitas tjuanitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we might want to differentiate between linting and formatting. im looking into if it's possible to run the lint-staged config against modified files in a PR. that seems like an easiest approach without having to keep these script files in sync

.circleci/config.yml
- setup-workspace
- run:
name: Typescript
command: yarn --cwd /buie tsc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is intended and related to the caching issue from a few weeks ago but the working directory defined at the top is ~/buie while all of these are commands occur at /buie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its intentional, I tried different combinations to get it to match without having to hardcode the working directory folder, this was the only combination that worked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these referring to separate directories though?

@greg-in-a-box
Copy link
Contributor Author

i think we might want to differentiate between linting and formatting. im looking into if it's possible to run the lint-staged config against modified files in a PR. that seems like an easiest approach without having to keep these script files in sync

I think the bigger issue is using the lint-staged commands via CI, since you can just --no-verify through the checks locally but you wouldnt be able to bypass the CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjuanitas tjuanitas tjuanitas left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg-in-a-box @tjuanitas