Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L_op of Blockwise #3

Closed

Conversation

purna135
Copy link

This PR adds:

  • get_output_info(), which is the same as Elemwise get_output_info(), to make all inputs of the same dimension.
  • derive DimShuffle's gufunc signature
  • reduce the broadcasted dimensions of inputs after the grad is computed

Things changed in this PR:

  • instead of using the dimensions from the start for computing the curr_static_shape of core_inp_grads use the dimensions from the end.
  • an extra check before calling perform() of DimShuffle (which can be removed later)

rlouf and others added 30 commits September 2, 2022 10:03
`ChoiceRV` currently does not behave like its NumPy equivalent when its
`a` parameters is an `int` or an array with more than one dimension. We
implement the necessary changes so that it does.
…information

Otherwise TestSharedOptions.test_specify_shape_inplace would fail
* Also fixes bug in JITCompiler when first output of inner fgraph is an input variable, as can happen in some specific functions with updates
@brandonwillard
Copy link
Owner

Closed in favor of aesara-devs#1215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants