Fix filter intended to exclude perf's own writes. #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
write_workaround
code paths weren't working as intended (which is bad, sinceperf
recording its own writes causes something of a feedback loop).The idea behind the trick being used is that
sh
substitutes its PID for$$
; thenexec
replacessh
withperf
(keeping the same PID), so we have managed to putperf
's own PID in the filter, which successfully excludesperf
's writes. (Yay!)This patch just restores the
exec
s, which must have gone missing at some point, and without which we are excludingsh
's writes instead.