Target Java 8 bytecode. #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was overlooked as part of dropping Java 7 support in NuProcess 3.0.
|
Is this something you think should be done, Brett? Without this, aside from documentation, I don't think we've actually dropped support for Java 7 in practice. If you do agree with this change, which release should we target it for? 3.0.1? 3.1.0? 4.0.0? Since you documented Java 7 support as removed in 3.0.0, I think it would be fair to consider this a bugfix and release it in 3.0.1. |
|
Also, is there any chance of getting the CircleCI build working again? Or disabling it if not? Having every commit and pull request report failed builds makes changes feel unsafe. (I'd be happy to dig into trying to get something working, but I lack the permissions necessary to do so.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked as part of dropping Java 7 support in NuProcess 3.0.