fix: wait for pool.end()

Because when you don't pass a callback to .end() it always returns a promise
brianc · Jun 18, 2024 · 0d7da49 · 0d7da49
1 parent e81fc3d
commit 0d7da49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/pg-pool/index.js b/packages/pg-pool/index.js
@@ -356,18 +356,17 @@ class Pool extends EventEmitter {
     if (isExpired) {
       this.log('remove expired client')
       this._expired.delete(client)
-      this._remove(client, this._pulseQueue.bind(this))
-      return
+      return this._remove(client, this._pulseQueue.bind(this))
     }
 
     // idle timeout
     let tid
     if (this.options.idleTimeoutMillis) {
       tid = setTimeout(() => {
         this.log('remove idle client')
-        this._remove(client)
+        this._remove(client, this._pulseQueue.bind(this))
       }, this.options.idleTimeoutMillis)
-
+      
       if (this.options.allowExitOnIdle) {
         // allow Node to exit if this is all that's left
         tid.unref()

diff --git a/packages/pg-pool/test/idle-timeout.js b/packages/pg-pool/test/idle-timeout.js
@@ -50,7 +50,7 @@ describe('idle timeout', () => {
       try {
         yield Promise.race([removal, timeout])
       } finally {
-        pool.end()
+        yield pool.end()
       }
     })
   )