Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load crypto utils #3012

Closed

Conversation

hloughrey
Copy link

Fix 2980

@brianc
Copy link
Owner

brianc commented Jun 26, 2023

Thank you!

@brianc
Copy link
Owner

brianc commented Jun 26, 2023

hmmm tests are failing in CI

@mschilde
Copy link

mschilde commented Jul 5, 2023

Wouldn't the fix be simply removing the return outside the function? https://github.com/brianc/node-postgres/blob/master/packages/pg/lib/crypto/utils.js#L7

Or wrap everything after the return into an else block? Currently pg v.8.11+ is broken for a number of users, so let's try to get this fixed.

@charmander
Copy link
Collaborator

Wouldn't the fix be simply removing the return outside the function?

no

Or wrap everything after the return into an else block?

sure

let's

pr?

Copy link
Collaborator

@charmander charmander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crypto/utils is also imported by lib/client.

@charmander charmander closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.11.0 - Return outside of function
4 participants