Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage and update readme #3114

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Clarify usage and update readme #3114

merged 2 commits into from
Jun 4, 2024

Conversation

irvinebroque
Copy link
Contributor

refs Ethan-Arrowood/socket#17

@petebacondarwin @brianc — publishing pg-cloudflare as a separate package seems to be really helpful to people. Ex:

https://github.com/sidorares/node-mysql2/pull/2289/files#diff-e56fabfb5e90fd8f6265cfbe84f3701a85261d884e198bf61de34958cee4864aR12

Added some docs to clarify usage, and cross link to the Node.js implementation of the Socket API.

refs Ethan-Arrowood/socket#17

@petebacondarwin @brianc — publishing `pg-cloudflare` as a separate package seems to be really helpful to people. Ex:

https://github.com/sidorares/node-mysql2/pull/2289/files#diff-e56fabfb5e90fd8f6265cfbe84f3701a85261d884e198bf61de34958cee4864aR12

Added some docs to clarify usage, and cross link to the Node.js implementation of the Socket API.
Copy link
Collaborator

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brianc
Copy link
Owner

brianc commented Dec 28, 2023

i dig it! Lint failing for some reason? On nothing but a markdown change? what in the hay hay?

@abenhamdine
Copy link
Contributor

i dig it! Lint failing for some reason? On nothing but a markdown change? what in the hay hay?

@brianc looks like Lint is failing in CI in every PR with this error :

TypeError: prettier.resolveConfig.sync is not a function

@brianc
Copy link
Owner

brianc commented Mar 5, 2024

looks like Lint is failing in CI in every PR with this error :

yeah annoying transitive dep break. Fixed on master if you wanna rebase. If you don't, I'll try rebasing for ya in a few days

@brianc
Copy link
Owner

brianc commented Mar 13, 2024

in a few days

like probably not for a week or two...but eventually I will! 😅

@brianc
Copy link
Owner

brianc commented Jun 4, 2024

like probably not for a week or two...but eventually I will! 😅

better late than never! thanks again!

@brianc brianc merged commit 5c846ca into brianc:master Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants