Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix devcontainer #3251

Merged
merged 8 commits into from
Jun 24, 2024
Merged

fix devcontainer #3251

merged 8 commits into from
Jun 24, 2024

Conversation

nigrosimone
Copy link
Contributor

@nigrosimone nigrosimone commented Jun 8, 2024

  • Fix: Debian stretch repo has been moved to archive.debian.org
  • Fix: Scam autentication required
  • Fix: Add missing library for pg-native
  • Fix: Internal network connection

Also fix #3049

@brianc
Copy link
Owner

brianc commented Jun 14, 2024

Thanks! Will be a bit slow to follow up as I'm in the mountains for a few more days - will be home in a few in case I seem awol.

@brianc
Copy link
Owner

brianc commented Jun 18, 2024

I'm a bit confused as to why the tests are failing? Nothing you changed should have impacted the tests at all afaict? any ideas?...

@nigrosimone
Copy link
Contributor Author

nigrosimone commented Jun 19, 2024

@brianc

I'm a bit confused as to why the tests are failing?

Into the github action the database host is "localhost" https://github.com/brianc/node-postgres/blob/master/.github/workflows/ci.yml#L52, Instead into devcontainer is "db" https://github.com/nigrosimone/node-postgres/blob/patch-1/.devcontainer/docker-compose.yml#L44.

The test run successfully into devcontainer, but fail into github action. Simply need to use the same host name.

Nothing you changed should have impacted the tests at all afaict?

This is the commit of hostname change fd1af11

@brianc
Copy link
Owner

brianc commented Jun 19, 2024

k - should probably revert the changes to the native test or make it consistent everywhere - can't merge this w/o tests passing!

@nigrosimone
Copy link
Contributor Author

@brianc I have reverted the failing test and made some other changes for latest vscode

@brianc
Copy link
Owner

brianc commented Jun 24, 2024

@nigrosimone thanks for your help! Will run tests & then merge this. ❤️

@brianc brianc merged commit b5281f5 into brianc:master Jun 24, 2024
5 checks passed
@nigrosimone nigrosimone deleted the patch-1 branch June 24, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devcontainer does not work for windows
2 participants