Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomization for ERB deployments #89

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Add kustomization for ERB deployments #89

merged 6 commits into from
Apr 16, 2024

Conversation

sjahl
Copy link
Collaborator

@sjahl sjahl commented Mar 29, 2024

This adds a base kustomization file for the exome results browsers, and reduces the deployment manifests down to their lowest common denominator, so that we can easily extend them for multiple environments.

An example of how you might further extend the base kustomization can be found here: https://github.com/broadinstitute/gnomad-deployments/tree/main/exome-results-browsers

@sjahl sjahl requested a review from rileyhgrant March 29, 2024 19:09
@sjahl sjahl self-assigned this Mar 29, 2024
Copy link
Contributor

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Thanks for taking the time to go over these changes, and more broadly about kustomize and other tools after standup today :), it was very helpful for my understanding.

@sjahl sjahl merged commit e597dd5 into main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants