fix: PR check (#117)

browserstack · Dec 16, 2024 · a28c105 · a28c105
1 parent ac57923
commit a28c105
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -10,7 +10,8 @@ module.exports = {
   },
   globals: {
     axe: true,
-    Promise: true
+    Promise: true,
+    a11yEngine: true
   },
   rules: {
     'no-bitwise': 2,

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -19,9 +19,7 @@ jobs:
           cache: 'npm'
       - run: npm ci
       - run: npm run build
-      # v4 download seems to have some flakiness with the download of artifacts so pinning to v3 for now
-      # @see https://github.com/actions/download-artifact/issues/249
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: axe-core
           path: axe.js

diff --git a/lib/checks/color/link-in-text-block-evaluate.js b/lib/checks/color/link-in-text-block-evaluate.js
@@ -4,7 +4,6 @@ import {
   getBackgroundColor,
   incompleteData
 } from '../../commons/color';
-import a11yEngineCommons from '../../commons/a11y-engine-index';
 
 function getContrast(color1, color2) {
   var c1lum = color1.getRelativeLuminance();
@@ -53,7 +52,7 @@ function linkInTextBlockEvaluate(node, options) {
     ) {
       return true;
     }
-    return a11yEngineCommons.distinguishableLinkEvaluate(node, parentBlock);
+    return a11yEngine.commons.distinguishableLinkEvaluate(node, parentBlock);
   }
 
   // Capture colors

diff --git a/lib/commons/a11y-engine-index.js b/lib/commons/a11y-engine-index.js