Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PR check #117

Merged
merged 3 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ module.exports = {
},
globals: {
axe: true,
Promise: true
Promise: true,
a11yEngine: true
},
rules: {
'no-bitwise': 2,
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ jobs:
cache: 'npm'
- run: npm ci
- run: npm run build
# v4 download seems to have some flakiness with the download of artifacts so pinning to v3 for now
# @see https://github.com/actions/download-artifact/issues/249
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: axe-core
path: axe.js
Expand Down
3 changes: 1 addition & 2 deletions lib/checks/color/link-in-text-block-evaluate.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
getBackgroundColor,
incompleteData
} from '../../commons/color';
import a11yEngineCommons from '../../commons/a11y-engine-index';

function getContrast(color1, color2) {
var c1lum = color1.getRelativeLuminance();
Expand Down Expand Up @@ -53,7 +52,7 @@ function linkInTextBlockEvaluate(node, options) {
) {
return true;
}
return a11yEngineCommons.distinguishableLinkEvaluate(node, parentBlock);
return a11yEngine.commons.distinguishableLinkEvaluate(node, parentBlock);
}

// Capture colors
Expand Down
6 changes: 0 additions & 6 deletions lib/commons/a11y-engine-index.js

This file was deleted.

Loading