Remove HandleReadModuleError
#2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is instead inlined because it's a core decision that Syncer should make.
| // If this func returns `LookbackDecisionCodeStop` for `ReadModuleErrorCodeModuleNotFound`, the | ||
| // syncer will stop looking when reaching the commit `u`, will select `v` as the start sync point, | ||
| // and the synced commits into the BSR will be [x, y, z]. | ||
| HandleReadModuleError(err *ReadModuleError) LookbackDecisionCode | ||
| // InvalidBSRSyncPoint is invoked by Syncer upon encountering a module's branch sync point that is |
There was a problem hiding this comment.
How is this error different than the ones when reading a module? Do you see this being customizable by some CLI flag?
There was a problem hiding this comment.
Nah I want to kill this, too. Initially all of this came because we were logging a warning in the CLI and the suggestion was made that Syncer shouldn't do this, but this is a core part of Syncer now.
unmultimedio
requested changes
Nov 15, 2023
unmultimedio
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is instead inlined because it's a core decision that Syncer should make.