Separate matchers as a bucket filter #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new read bucket called Filter that works exclusively on Matchers. This allows for using Matchers to constrain the bucket walk path. Buckets that use Matchers as Mappers have been split as a Mapper and Filter bucket. The method MapPrefix on Mappers has been removed. Matchers no longer implement Mappers.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
commented
Aug 12, 2024
| // The path is expected to be normalized and validated. | ||
| // The returned path is expected to be normalized and validated. | ||
| // If the path cannot be mapped, this returns false. | ||
| MapPrefix(prefix string) (string, bool) |
There was a problem hiding this comment.
MapPrefix can be removed and replaced with calls to MapPath now that Matchers won't restrict the mappers.
| @@ -82,123 +85,47 @@ func MatchNot(matcher Matcher) Matcher { | |||
|
|
|||
| // We limit or/and/not to Matchers as composite logic must assume | |||
| // the input path is not modified, so that we can always return it | |||
| // | |||
| // We might want to just remove Matcher implementing Mapper for simplification, | |||
| // and just have a Matches function, then handle chaining them separately. | |||
There was a problem hiding this comment.
Removed, Matchers no longer implement Mappers.
| // | ||
| // If the Matchers are empty, the original ReadBucket is returned. | ||
| // If there is more than one Matcher, the Matchers are anded together. | ||
| func FilterReadBucket(readBucket ReadBucket, matchers ...Matcher) ReadBucket { |
There was a problem hiding this comment.
Chose FilterReadBucket over MatchReadBucket, the naming of filter with the filter funcs being called matchers I think is still clear. We could also rename Matchers to FIlters?
emcfarlane
changed the title
bufdev
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new read bucket Filter that works exclusively on Matchers. This allows for further optimizations by using the Matchers to constrain the bucket walk path (see #3230). Buckets that use Matchers as Mappers have been split as a Mapper and Filter bucket. The method MapPrefix on Mappers has been removed. Matchers no longer implement Mappers.