Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotation for FIELD_NOT_REQUIRED rule #3483

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix annotation for FIELD_NOT_REQUIRED rule #3483

merged 1 commit into from
Nov 20, 2024

Conversation

doriable
Copy link
Member

The annotation for FIELD_NOT_REQUIRED did not
pass in the field name.

@doriable doriable requested a review from oliversun9 November 20, 2024 17:27
@github-actions GitHub Actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 20, 2024, 5:27 PM

oliversun9
oliversun9 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@oliversun9 oliversun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@doriable doriable merged commit 326f8d3 into main Nov 20, 2024
12 checks passed
@doriable doriable deleted the fix-lint-annotation branch November 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliversun9 oliversun9 oliversun9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doriable @oliversun9