Have SemanticTokensFull
return nil
when no symbols are available for the file
#3531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file does not have parsed symbols, we are currently
sending a
nil
slice for the data in semantic tokens.The specification for
textDocument/semanticTokens/full
outlines thatthe expected response is
SemanticTokens | null
, whereSemanticTokens
is defined as:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_semanticTokens
data
is not an optional field forSemanticTokens
, so setting it tonil
causes failures on clients:
From the LSP logs:
We should instead be returning
nil
forSemanticTokensFull
in this case, whichis expected by clients.
LSP logs after the change: