Stagger lint and breaking checks in LSP Refresh #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bufdev
approved these changes
Dec 16, 2024
mcy
reviewed
Dec 16, 2024
| go func() { | ||
| // Call TryLock, if unnsuccessful, then another thread holds the lock, so we provide a | ||
| // debug log and move on. | ||
| if !f.lsp.lock.TryLock() { |
There was a problem hiding this comment.
This is out of order. You want to sleep first, then attempt to grab the lock. Otherwise, this blocks requests from the LSP, which will mean the generated lints won't use the most recent content.
emcfarlane
reviewed
Dec 16, 2024
emcfarlane
reviewed
Dec 16, 2024
emcfarlane
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since lint and breaking change detection are more
expensive, we do not need to run them on every single
file refresh. Instead, we use the top-level LSP lock and a
short stagger (5ms) and only run when the attempt to get
the top-level lock is successful. Otherwise, we no-op and
assume that the checks are handled by another
Refreshrequest.