Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a provider from a rule instead of a struct #1200

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mering
Copy link
Contributor

@mering mering commented Dec 15, 2024

This is now longer allowed in Bazel 8 and was flipped via --incompatible_disallow_struct_provider_syntax.

Once merged, please also backport to the v1.1.1-SNAPSHOTS.

This is now longer allowed in Bazel 8 and was flipped
via --incompatible_disallow_struct_provider_syntax.
@CLAassistant
Copy link

CLAassistant commented Dec 15, 2024

CLA assistant check
All committers have signed the CLA.

meteorcloudy pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request Dec 16, 2024
This returns DefaultInfo in rules instead of a plain struct() (backports
bufbuild/protoc-gen-validate#1200).
@mering
Copy link
Contributor Author

mering commented Dec 16, 2024

@rodaine could you PTAL? Thx.

@mering
Copy link
Contributor Author

mering commented Dec 16, 2024

Changing PR title as "Always" ends with an "s" even though it is not third person verb:

Error: PR titles must start with a capital letter, not end the first word in 's' (ideally the imperative, present tense!), and not end with punctuation.

@mering mering changed the title Always return a provider from a rule instead of a struct Return a provider from a rule instead of a struct Dec 16, 2024
@rodaine rodaine merged commit 2f3df6b into bufbuild:main Dec 17, 2024
5 of 8 checks passed
@mering mering deleted the fix-rule-provider branch December 20, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants