Support Expo SDK 49 #139
Merged
Support Expo SDK 49 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed
gingerbenw
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds support for Expo SDK 49
Changeset
updates dependencies to support expo 49
updates the test fixture to use expo 49
also bumps bugsnag-js dependencies
Testing
Mostly relied on CI but also manually tested that iOS source map uploads are still uploaded as there have been some changes in SDK 49 around how the bundle is generated on iOS (see https://blog.expo.dev/expo-sdk-49-c6d398cdf740)
It looks like in Expo 49 EAS Build no longer sets the
android:usesCleartextTrafficattribute by default, meaning non-https traffic is now blocked by default on Android.This broke the test fixture since requests to mazerunner are made over http - to get around this a config plugin has been added to the fixture to set this attribute in the Android manifest during prebuild.