Ensure EAS sourcemap config plugin is idempotent #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
force-pushed
the
PLAT-11047/idempotent-config-plugin
branch
from
11e91d8
to
26ed5bb
Compare
yousif-bugsnag
force-pushed
the
PLAT-11047/idempotent-config-plugin
branch
from
26ed5bb
to
d3c9b83
Compare
gingerbenw
reviewed
Oct 26, 2023
|
|
||
| ### Added | ||
|
|
||
| - (delivery-expo) Explicitly mark failed payloads >1MB as not retryable [#65](https://github.com/bugsnag/bugsnag-expo/pull/65) |
There was a problem hiding this comment.
was this one missing from a previous PR?
There was a problem hiding this comment.
yeah this one: #65
gingerbenw
approved these changes
Nov 1, 2023
|
@gingerbenw Is it possible to create the |
Merged
|
Hi @pzatorski, we have just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates the iOS config plugin in
@bugsnag/plugin-expo-eas-sourcemapsto ensure it can be run repeatedly.This fixes an issue where the plugin would add duplicate build phases to the iOS project if
expo prebuildis run repeatedly without the--cleanoption (#148)Note that the Android config plugin is unaffected.
Testing
CI plus manual testing