Fix build issues #157
Merged
Fix build issues #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
v47/update-expo-dependencies
branch
from
2ad337c
to
fe9b0cd
Compare
gingerbenw
force-pushed
the
v47/update-expo-dependencies
branch
from
dbf37de
to
d5b5ba3
Compare
imjoehaines
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR resolves build issues with Expo 47 by using the hermes engine as described in the following issue and updates the version of react-native to match the one expected in
expo-doctorThis also removes a previoiusly pinned dependency resolution implemented for a known expo issue