remove js payload limit

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## TBD
+
+### Changed
+
+- Attempt to send all event and session payloads, regardless of size
+
 ## v7.18.0 (2022-09-22)
 
 ### Changed

packages/core/lib/json-payload.js

@@ -15,13 +15,11 @@ Serialized payload was ${payload.length / 10e5}MB (limit = 1MB)
 metadata was removed`
     }
     payload = jsonStringify(event, null, null, { redactedPaths: EVENT_REDACTION_PATHS, redactedKeys })
-    if (payload.length > 10e5) throw new Error('payload exceeded 1MB limit')
   }
   return payload
 }
 
-module.exports.session = (event, redactedKeys) => {
-  const payload = jsonStringify(event, null, null)
-  if (payload.length > 10e5) throw new Error('payload exceeded 1MB limit')
+module.exports.session = (session, redactedKeys) => {
+  const payload = jsonStringify(session, null, null)
   return payload
 }

packages/delivery-electron/delivery.js

@@ -18,6 +18,11 @@ const delivery = (client, filestore, net, app) => {
       } else {
         const err = new Error(`Bad status code from API: ${response.statusCode}`)
         err.isRetryable = isRetryable(response.statusCode)
+        // do not retry oversized payloads regardless of status code
+        if (body.length > 10e5) {
+          client._logger.warn(`Discarding over-sized event (${body.length / 10e5} MB) after failed delivery`)
+          err.isRetryable = false
+        }
         cb(err)
       }
     })

packages/delivery-electron/test/delivery.test-main.ts

@@ -207,6 +207,39 @@ describe('delivery: electron', () => {
     })
   })
 
+  it('does not attempt to re-send oversized payloads', done => {
+    // A 401 is considered retryable but this will be override by the payload size check
+    const { requests, server } = mockServer(401)
+    server.listen(err => {
+      expect(err).toBeUndefined()
+
+      const lotsOfEvents: any[] = []
+      while (JSON.stringify(lotsOfEvents).length < 10e5) {
+        lotsOfEvents.push({ errors: [{ errorClass: 'Error', errorMessage: 'long repetitive string'.repeat(1000) }] })
+      }
+      const payload = {
+        events: lotsOfEvents
+      } as unknown as EventDeliveryPayload
+
+      const config = {
+        apiKey: 'aaaaaaaa',
+        endpoints: { notify: `http://localhost:${(server.address() as AddressInfo).port}/notify/` },
+        redactedKeys: []
+      }
+
+      let didLog = false
+      const logger = { error: () => { didLog = true }, info: () => {} }
+      delivery(filestore, net, app)(makeClient(config, logger)).sendEvent(payload, (err: any) => {
+        expect(didLog).toBe(true)
+        expect(enqueueSpy).not.toHaveBeenCalled()
+        expect(err).toBeTruthy()
+        expect(requests.length).toBe(999)
+        server.close()
+        done()
+      })
+    })
+  })
+
   it('handles errors gracefully for sessions (ECONNREFUSED)', done => {
     const payload = {
       events: [{ errors: [{ errorClass: 'Error', errorMessage: 'foo is not a function' }] }]

packages/delivery-node/delivery.js

@@ -3,8 +3,13 @@ const request = require('./request')
 
 module.exports = (client) => ({
   sendEvent: (event, cb = () => {}) => {
+    const body = payload.event(event, client._config.redactedKeys)
+
     const _cb = err => {
       if (err) client._logger.error(`Event failed to send…\n${(err && err.stack) ? err.stack : err}`, err)
+      if (body.length > 10e5) {
+        client._logger.warn(`Event oversized (${body.length / 10e5} MB)`)
+      }
       cb(err)
     }
 
@@ -17,7 +22,7 @@ module.exports = (client) => ({
           'Bugsnag-Payload-Version': '4',
           'Bugsnag-Sent-At': (new Date()).toISOString()
         },
-        body: payload.event(event, client._config.redactedKeys),
+        body,
         agent: client._config.agent
       }, (err, body) => _cb(err))
     } catch (e) {

packages/delivery-x-domain-request/delivery.js

@@ -3,14 +3,22 @@ const payload = require('@bugsnag/core/lib/json-payload')
 module.exports = (client, win = window) => ({
   sendEvent: (event, cb = () => {}) => {
     const url = getApiUrl(client._config, 'notify', '4', win)
+    const body = payload.event(event, client._config.redactedKeys)
+
     const req = new win.XDomainRequest()
     req.onload = function () {
       cb(null)
     }
+    req.onerror = function () {
+      client._logger.error('Event failed to send…\n')
+      if (body.length > 10e5) {
+        client._logger.warning(`Event oversized (${body.length / 10e5} MB)`)
+      }
+    }
     req.open('POST', url)
     setTimeout(() => {
       try {
-        req.send(payload.event(event, client._config.redactedKeys))
+        req.send(body)
       } catch (e) {
         client._logger.error(e)
         cb(e)

packages/delivery-xml-http-request/delivery.js

@@ -5,15 +5,26 @@ module.exports = (client, win = window) => ({
     try {
       const url = client._config.endpoints.notify
       const req = new win.XMLHttpRequest()
+      const body = payload.event(event, client._config.redactedKeys)
+
       req.onreadystatechange = function () {
-        if (req.readyState === win.XMLHttpRequest.DONE) cb(null)
+        if (req.readyState === win.XMLHttpRequest.DONE) {
+          const status = req.status
+          if (status === 0 || status >= 400) {
+            client._logger.error('Event failed to send…\n')
+            if (body.length > 10e5) {
+              client._logger.warning(`Event oversized (${body.length / 10e5} MB)`)
+            }
+          }
+          cb(null)
+        }
       }
       req.open('POST', url)
       req.setRequestHeader('Content-Type', 'application/json')
       req.setRequestHeader('Bugsnag-Api-Key', event.apiKey || client._config.apiKey)
       req.setRequestHeader('Bugsnag-Payload-Version', '4')
       req.setRequestHeader('Bugsnag-Sent-At', (new Date()).toISOString())
-      req.send(payload.event(event, client._config.redactedKeys))
+      req.send(body)
     } catch (e) {
       client._logger.error(e)
     }