CI: generate openapi contract before asking for contract diff #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulRbr
force-pushed
the
generate-openapi-diff
branch
9 times, most recently
from
552efab
to
07007b5
Compare
paulRbr
force-pushed
the
generate-openapi-diff
branch
from
07007b5
to
0902340
Compare
With this commit: Review can be deleted (operation added) Boon can not be deleted (operation removed, this is a breaking change)
|
🚨 Breaking API change detected: Added (1)
Removed (1)
|
Polo2
reviewed
Oct 17, 2023
| - name: Comment pull request with API diff | ||
| uses: bump-sh/github-action@v1 | ||
| with: | ||
| doc: apiplatform-test-demo | ||
| token: ${{secrets.BUMP_TOKEN}} | ||
| file: docs/openapi.json | ||
| file: api/openapi.json |
There was a problem hiding this comment.
is it possible to keep contract on same file docs/openapi.json ?
There was a problem hiding this comment.
Or does it mean openapi contract is not persisted anymore (there is no file api/openapi.json with second commit)
| options: -v ${{github.workspace}}/api:/srv/app -v /srv/app/vendor | ||
| run: | | ||
| composer require symfony/runtime | ||
| php bin/console api:openapi:export > openapi.json |
There was a problem hiding this comment.
is it possible to keep contract on same file docs/openapi.json ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional step to automatically generate to API contract in the CI step.