Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand: set new logo and icon #307

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Rebrand: set new logo and icon #307

merged 1 commit into from
Dec 2, 2024

Conversation

fbraure
Copy link
Contributor

@fbraure fbraure commented Nov 26, 2024

Notion Check list
Drive

To be validated with @grossyoan before technical review.

@fbraure fbraure requested a review from grossyoan November 26, 2024 23:37
@fbraure fbraure self-assigned this Nov 26, 2024
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit 190dbf7
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/67465bb67ffba500084f47b4
😎 Deploy Preview https://deploy-preview-307--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fbraure fbraure marked this pull request as draft November 26, 2024 23:37
Copy link
Contributor

@grossyoan grossyoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Flo!

It's great for the logo.
Just a small feedback regarding the favicon: it doesn't switch to white in dark mode.

It doesn't either with the current website/logo, but that would be great (if it's not too time consuming) to have it properly working now (as we do the switch on the main website).

image

@fbraure fbraure marked this pull request as ready for review December 2, 2024 08:15
@fbraure fbraure merged commit 2b5ebbb into main Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants