Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: make sure to differentiate No Change vs Content change only #498

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented Jun 20, 2024

This commit makes sure to have a different behavior during a diff
between a No Change at all result, vs a No Content Change result.

Before this commit we would only display a “No diff found” message in
the GH action logs.

With this new commit, if there's a content change detected we now
publish a comment containing a link to be able to preview the change.

@paulRbr paulRbr self-assigned this Jun 20, 2024
@paulRbr paulRbr requested a review from fbraure June 20, 2024 15:02
This commit makes sure to have a different behavior during a diff
between a No Change at all result, vs a No Content Change result.

Before this commit we would only display a “No diff found” message in
the GH action logs.

With this new commit, if there's a content change detected we now
publish a comment containing a link to be able to preview the change.
Copy link

@fbraure fbraure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pair review

@paulRbr paulRbr merged commit c0389dc into bump-sh:master Jun 25, 2024
4 checks passed
@paulRbr paulRbr deleted the clarify-no-diff-found branch June 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants