Implement ActiveSupport::Notifications

[ChrisBr]

Adding ActiveSupport Notifications similar to what ActiveRecord already does.

[coveralls]

Coverage increased (+0.04%) to 96.538% when pulling 58fe921 on ChrisBr:cbruckmayer/implement-as-notifications into a84a934 on byroot:master.

[casperisfine]

Hum. I'm of two minds on this. On one hand it's very simple, on the other it's a bit of an overhead for something that I don't see used much.

Maybe it would make sense to have this as a module that could be optionally included when you want it?

[ChrisBr]

Yeah, makes sense. That is what we do at the moment in Core.

  module FrozenRecordTracingPatch
    def matching_records
      ActiveSupport::Notifications.instrument('query.frozen_record', path: @klass.file_path) do
        super
      end
    end
  end
  FrozenRecord::Scope.prepend(FrozenRecordTracingPatch)

Just wanted to discuss if we wanted to include it upstream. Do you want it to include it as module here or just leave it for now?

[casperisfine]

Do you want it to include it as module here

I'd be fine with this. e.g. include FrozenRecord::Instrumentation

[rafaelfranca]

Agree we can provide an instrumentation module if people want to use without making it the default.