Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual ACK packet support #855

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

xiaocq2001
Copy link
Contributor

A solution for issue #841 and issue #609.

Note the example of async_manual_acks_v5 needs PR #854 to make broker re-send publishes.

Type of change

New feature (non-breaking change which adds functionality)

  • get_manual_ack to return manual ack packet where
    • set_reason/set_code to update reason code
    • set_reason_string to set reason string
    • set_user_properties to set user properties
  • manual_ack/try_manual_ack to send the modified packet (PUBACK/PUBREC) returned by get_manual_ack

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@xiaocq2001
Copy link
Contributor Author

Are there any additional comments or feedback? If this solution is acceptable, could you please advise on the steps I can take to expedite the merging process?

@xiaocq2001
Copy link
Contributor Author

Added some docs about the API usage.
Added two different ack way in example code and detailed comments on them.

Please check.

@xiaocq2001
Copy link
Contributor Author

Any comments?

@xiaocq2001
Copy link
Contributor Author

Any comments on manual ACK with reason code support here?

@xiaocq2001
Copy link
Contributor Author

Is there any chance to merge this PR? It appears to be relatively independent and should not affect other ongoing discussions.

@ryanwinter
Copy link

Hello, is there anything else needed to move this PR forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants