Fall back to TCGETS if TCGETS2 fails
#1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch `tcgetattr`/`tcsetattr` from using `TCGETS2`/`TCSETS2` first to using `TCGETS`/`TCSETS` first. Have `tcgetattr` fall back to `TCGETS2` if the `TCGETS` flags indicate that a custom speed is in used. glibc and musl have not yet migrated to `TCGETS2`/`TCSETS2`, and as a result, seccomp sandboxes and Linux-like environments such as WSL don't always support them. Also, fix some bugs in QEMU related to the handling of termios syscalls. This eliminates the need for having rustix do extra fixups on PowerPC. This is expected to fix crossterm-rs/crossterm#912.
sunfishcode
force-pushed
the
sunfishcode/tcgets-new
branch
from
f511157
to
9e7d4d7
Compare
This allows more of the fallback code to be done in `cold` functions, and makes the code easier to follow.
Also fix capitalization in various comments.
sunfishcode
force-pushed
the
sunfishcode/tcgets-new
branch
from
a1ce30f
to
c4ef05f
Compare
sunfishcode
changed the title
TCGETS before trying TCGETS2.TCGETS if TCGETS2 fails
|
This is now released in rustix 0.38.36. |
fornwall
added a commit
to termux/termux-packages
that referenced
this pull request
Sep 5, 2024
fornwall
added a commit
to termux/termux-packages
that referenced
this pull request
Sep 5, 2024
termux-pacman-bot
added a commit
to termux-pacman/termux-packages
that referenced
this pull request
Sep 5, 2024
fornwall
added a commit
to fornwall/nushell
that referenced
this pull request
Sep 19, 2024
Notable this gets bytecodealliance/rustix#1147 which makes things work on Android again.
fornwall
added a commit
to fornwall/broot
that referenced
this pull request
Sep 19, 2024
This gets bytecodealliance/rustix#1147, a fix that makes things work on Android again (see Canop#940 - this is the patch Termux carries when building latest broot).
fornwall
added a commit
to fornwall/nushell
that referenced
this pull request
Sep 26, 2024
Notable this gets bytecodealliance/rustix#1147 which makes things work on Android again.
sholderbach
pushed a commit
to nushell/nushell
that referenced
this pull request
Sep 26, 2024
Notable this gets bytecodealliance/rustix#1147 which makes things work on Android again. Without this update latest `0.98.0` release gets stuck in a loop outputting the below error due to the `TCGETS2` usage: > Error: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch
tcgetattr/tcsetattrfrom usingTCGETS2/TCSETS2first to usingTCGETS/TCSETSfirst. Havetcgetattrfall back toTCGETS2if theTCGETSflags indicate that a custom speed is in used.glibc and musl have not yet migrated to
TCGETS2/TCSETS2, and as a result, seccomp sandboxes and Linux-like environments such as WSL don't always support them.Also, fix some bugs in QEMU related to the handling of termios syscalls. This eliminates the need for having rustix do extra fixups on PowerPC.
This is expected to fix crossterm-rs/crossterm#912.