A better fix for #173

Prepare to re-release.
c-blake · Nov 23, 2020 · 71699d7 · 71699d7
1 parent 39b9c98
commit 71699d7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -1,6 +1,15 @@
 RELEASE NOTES
 =============
 
+Version: 1.3.2
+--------------
+  Remove prefetching optimization idea, anyway.  On AMD 2950X, it was quite a
+  bit slower anyway.
+
+  Better fix to deactivate prefetch doing anything unless user activates (and
+  maybe uses special gcc flags, too.).  `cligen/prefix` module is retained for
+  backward compatibility { no longer touching compiler flags at all }.
+
 Version: 1.3.1
 --------------
   Quick fix to deactivate mslice prefetch causing build problems for some.

diff --git a/cligen.nimble b/cligen.nimble
@@ -1,5 +1,5 @@
 # Package
-version     = "1.3.1"
+version     = "1.3.2"
 author      = "Charles Blake"
 description = "Infer & generate command-line interace/option/argument parser"
 license     = "MIT/ISC"

diff --git a/cligen/prefetch.nim b/cligen/prefetch.nim
@@ -8,8 +8,8 @@ type
     pfEvictL2   = 2
     pfEvictNone = 3
 
-when defined(x86prefetch) and defined(gcc): #XXX or defined(clang) etc.
-  {.passc: "-march=native".}
+#XXX or defined(clang) etc. You may need some gcc flags for this to do anything.
+when defined(cpuPrefetch) and defined(gcc):
   proc prefetch*(data: pointer, rw=pfRead, kind=pfEvictNone) {.
     importc: "__builtin_prefetch", nodecl .}
   proc prefetchw*(data: pointer, kind=pfEvictNone) {.inline.} =