Big refactor to make the backend registerable and swappable #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
added
the
BREAKING CHANGE
jgaskins
reviewed
May 6, 2024
There was a problem hiding this comment.
Thank you so much for finding a way to push this through! I remember when we left off before there was some confusion around blocks passed to Habitat setting macros and I never followed up on it.
Would it be possible to throw a Co-authored-by trailer on the commit message for 2ab304e?
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
|
Sweet! Got some green. @jgaskins added you in there, thanks! Yeah, I found out Habitat will need a few major refactors in order to support the annotations and block values. For now I just decided since Cable isn't 1.0, let's just break stuff 😂 The current v0.3.1 release is up to date with commits before this PR, so moving forward, I think we can just roll out v0.4.0 with the updated interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #88
This pulls in some code from #79
This is a big breaking change:
redis_ping_intervalis renamed tobackend_ping_intervalping_redis_subscribeis renamed toping_subscribe_connectionping_redis_publishis renamed toping_publish_connectionCable::RedisPingeris renamed toCable::BackendPingerENV["REDIS_URL"]is nowENV["CABLE_BACKEND_URL"]CloseRedisFiberdidn't seem to be used anywhere so it was removedregister "scheme"redisis no longer required out of the boxThe next few PRs will be removing the redis backend completely and moving it to a separate shard. I'll be making 2 different redis backend shards to allow using either shard without conflicts.
cc. @jgaskins