Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flakes support #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add flakes support #127

wants to merge 1 commit into from

Conversation

blackheaven
Copy link

Tackles #47

@blackheaven
Copy link
Author

Failures aren't linked to my PR, as there are the same errors in master

@blackheaven
Copy link
Author

@domenkozar is there anything I can do/improve to get it merged?

1 similar comment
@blackheaven
Copy link
Author

@domenkozar is there anything I can do/improve to get it merged?

@domenkozar
Copy link
Member

The problem is that by default you'd want all builds things to be in the cache, which is currently not possible for nix flake check since it doesn't have --json output.

@blackheaven
Copy link
Author

I'm not sure to see where I call nix flake check --json

@domenkozar
Copy link
Member

It's not supported yet, so it first needs to be added to Nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackheaven @domenkozar