Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowUnfree and overlays #383

Merged
merged 8 commits into from
Feb 28, 2023
Merged

allowUnfree and overlays #383

merged 8 commits into from
Feb 28, 2023

Conversation

domenkozar
Copy link
Member

@domenkozar domenkozar commented Feb 9, 2023

Fixes #154 #185

You can now do devenv.yaml:

allowUnfree: true
inputs:
  nixpkgs:
    url: github:NixOS/nixpkgs/nixpkgs-unstable
  rust-overlay:
    url: github:oxalica/rust-overlay
    overlays:
      - default

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9698a12
Status: ✅  Deploy successful!
Preview URL: https://f4c7ded5.devenv.pages.dev
Branch Preview URL: https://unfree-and-overlays.devenv.pages.dev

View logs

@shyim
Copy link
Contributor

shyim commented Feb 9, 2023

Will this need that the user update devenv on their machine or is it enough that youre modules update

@domenkozar
Copy link
Member Author

You'll need to update devenv :)

@kubukoz
Copy link

kubukoz commented Feb 9, 2023

Works great for me!

@domenkozar have you thought about the UX of this? e.g. if someone tries to use this feature with an older version, can we nudge them towards an update? I guess that'd have to be a generic "couldn't parse config, maybe you need to update?" message.

@domenkozar
Copy link
Member Author

I was thinking about the UX. Now that we use strictyaml for validation we can do this and nudge people to upgrade.

I'm also thinking to add a field like minimalVersion: XXX to devenv.yaml that would kind of tell users straight away which version the project needs.

@domenkozar
Copy link
Member Author

Moved the scope for the UX into #388

@kubukoz
Copy link

kubukoz commented Feb 10, 2023

:shipit:

src/devenv-yaml.nix Outdated Show resolved Hide resolved
Co-authored-by: Hugo Sena Ribeiro <hugosenari@gmail.com>
src/devenv-yaml.nix Outdated Show resolved Hide resolved
src/devenv-yaml.nix Outdated Show resolved Hide resolved
Co-authored-by: Hugo Sena Ribeiro <hugosenari@gmail.com>
Co-authored-by: Hugo Sena Ribeiro <hugosenari@gmail.com>
@domenkozar domenkozar merged commit 1b7ea64 into main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unfree and overlays
5 participants