reverse_proxy: Allow 0 as weights #6388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mholt
requested changes
Jun 12, 2024
| if weightInt < 1 { | ||
| return d.Errf("invalid weight value '%s': weight should be non-zero and positive", weight) | ||
| if weightInt < 0 { | ||
| return d.Errf("invalid weight value '%s': weight should be positive", weight) |
There was a problem hiding this comment.
Suggested change
| return d.Errf("invalid weight value '%s': weight should be positive", weight) | |
| return d.Errf("invalid weight value '%s': weight should be non-negative", weight) |
0 isn't positive but is also allowed now 😉
There was a problem hiding this comment.
Good question, I don't have the enough knowledge to write the test case for this. Any guide would be helpful.
There was a problem hiding this comment.
Have you at least tested various configs yourself to ensure they work? If so that's probably enough to start with.
But it looks like the existing tests are in selectionpolicies_test.go at func TestWeightedRoundRobinPolicy(t *testing.T) {. You could test a zero-weight in there as well.
There was a problem hiding this comment.
Thank you for your reply, will work on generating the test case.
Change positive to non-negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable 0 weights to be allowed when using weighted_round_robin policy with cookie. Discussed in https://caddy.community/t/invalid-weight-value/24440