-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 Update torch to 2.3.1 #368
Conversation
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
…h lib update Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Changes result vector comparison to approximately.
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: Flavia Beo <flavia.beo@ibm.com>
Adds tolerance params
0bec177
to
18e2fd8
Compare
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
18e2fd8
to
f4883e3
Compare
@@ -1018,7 +1018,7 @@ def test_encoding_order(loaded_model: EmbeddingModule, truncate_input_tokens): | |||
|
|||
# test order by comparing value of individual embeddings in sequence | |||
for i, e in enumerate(separate_vectors): | |||
assert np.allclose(e, combined_vectors[i]) | |||
assert np.isclose(e, combined_vectors[i], rtol=1e-03, atol=1e-05).all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q - what's the difference between isclose.all()
here vs. allclose
? Can't allclose
also take the rtol etc. https://numpy.org/doc/stable/reference/generated/numpy.allclose.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q on the isclose
but otherwise LGTM
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
7dfe5bc
to
9e3dda6
Compare
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the update!
Changes