🥅 Catch InactiveError for TGIS to modify error message #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkumbhat
requested review from
alex-jw-brooks,
evaline-ju,
gabe-l-hart,
tharapalanivel and
Ssukriti
as code owners
gkumbhat
force-pushed
the
add_tgis_inactive_error
branch
3 times, most recently
from
9e463dc to
285ae7c
Compare
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
gkumbhat
force-pushed
the
add_tgis_inactive_error
branch
from
285ae7c to
226d7b8
Compare
evaline-ju
reviewed
Aug 2, 2024
| @@ -474,6 +474,13 @@ def unary_generate( | |||
| batch_response = self.tgis_client.Generate( | |||
| request, timeout=self.tgis_req_timeout | |||
| ) | |||
| except grpc._channel._InactiveRpcError as err: | |||
| log.error("<NLP30829218E>", err.details) | |||
| error_message = "The underlying TCP connection is closed" | |||
There was a problem hiding this comment.
nit: const for future use, in case this has to go in other places?
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
InactiveErrorand through more helpful error message.