Update sentence-transformers and allow setting trust_remote_code #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentence-transformers APIs changed. This update allows 3.x (so far). The update is required to support some models. Most of the update is adding new params to be in sync with the super SentenceTransformer class. Most of these params are not used. Support is added to allow passing the trust_remote_code paramater. This can be done in the runtime config or with EMBEDDING_TRUST_REMOTE_CODE=true (or =1) environment variable. Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
markstur
requested review from
alex-jw-brooks,
gkumbhat,
evaline-ju,
gabe-l-hart,
tharapalanivel and
Ssukriti
as code owners
Setting PYTORCH_ENABLE_MPS_FALLBACK=1 allows the tests to run on Mac MPS (M3). Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
* Use >= 4.38.0 because that is the sentence-transformers min anyway. * Add <= 4.44.0 because 4.44.0 breaks our tests with errors like this: > `RuntimeError: The expanded size of the tensor (22) must match the existing size (30) at non-singleton dimension 2. Target sizes: [4, 22, 22]. Tensor sizes: [4, 1, 30]` Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
evaline-ju
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentence-transformers APIs changed. This update supports 3.0.x (to date). The update is required to support some models.
Most of the update is adding new params to be in sync with the super SentenceTransformer class. Most of these params are not used.
Support is added to allow passing the trust_remote_code parameter. This can be done in the runtime config or with EMBEDDING_TRUST_REMOTE_CODE=true (or =1) environment variable.