-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File type check on macosx (if file is "dylib") #4206
File type check on macosx (if file is "dylib") #4206
Conversation
@devlead @patriksvensson @gep13 Hi Would you be so kind and review this PR, please? We have blocking issue on GPS-FB-MLKit (GooglePlayServicesComponents) both local and CI builds |
Co-authored-by: Mattias Karlsson <mattias@devlead.se>
/azp run |
Commenter does not have sufficient privileges for PR 4206 in repo cake-build/cake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moljac Other than the missing periods in extensions it LGTM 👍
Could you please address, rebase against latest upstream develop branch, and squash/fixup into one commit, then I'll take a final look.
Co-authored-by: Mattias Karlsson <mattias@devlead.se>
I cannot squash. Probably because I updated branch with merge commit (I was in a hurry and doing few things in parallel) and forgot to squash before update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@moljac your changes have been merged, thanks for your contribution 👍 |
@moljac FYI a pre-release package is now available on our Azure Artifacts feed: |
Great! It works locally. 2 GPS-FB-MLKit PRs build nicely. When is 3.2.0 supposed to be released? Thanks a lot! |
Some feedback: 3.2.0 preview fixes the issue. Confimed on 2 local MBPs and on CI (GPS-FB-MLKit repo https://github.com/xamarin/GooglePlayServicesComponents) thanks |
Context: #3996
Added filetype/extension check.
Error experienced:
The error was experienced at intermittent intervals in CI (and local, but not so often) builds for 2 repos:
https://github.com/xamarin/AndroidX
https://github.com/xamarin/GooglePlayServicesComponents
In last few weeks, alsmost all builds fail regularly.
xamarin/GooglePlayServicesComponents#801