rename methods isFirstHalf and isSecondHalf

cakephp · Sep 19, 2023 · 9a0eac4 · 9a0eac4
1 parent adebd62
commit 9a0eac4
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/Chronos.php b/src/Chronos.php
@@ -2061,7 +2061,7 @@ public function isLastYear(): bool
      *
      * @return bool
      */
-    public function isFirstHalfOfYear(): bool
+    public function isFirstHalf(): bool
     {
         return $this->half === 1;
     }
@@ -2071,7 +2071,7 @@ public function isFirstHalfOfYear(): bool
      *
      * @return bool
      */
-    public function isSecondHalfOfYear(): bool
+    public function isSecondHalf(): bool
     {
         return $this->half === 2;
     }

diff --git a/src/ChronosDate.php b/src/ChronosDate.php
@@ -1231,7 +1231,7 @@ public function isLastYear(DateTimeZone|string|null $timezone = null): bool
      *
      * @return bool
      */
-    public function isFirstHalfOfYear(): bool
+    public function isFirstHalf(): bool
     {
         return $this->half === 1;
     }
@@ -1241,7 +1241,7 @@ public function isFirstHalfOfYear(): bool
      *
      * @return bool
      */
-    public function isSecondHalfOfYear(): bool
+    public function isSecondHalf(): bool
     {
         return $this->half === 2;
     }

diff --git a/tests/TestCase/Date/IsTest.php b/tests/TestCase/Date/IsTest.php
@@ -381,7 +381,7 @@ public function testIsWithinNext()
     public function testIsFirstOrSecondHalfOfYear(int $month, bool $isFirstHalfOfYear, bool $isSecondHalfOfYear): void
     {
         $d = Chronos::createFromDate(2023, $month, 1);
-        $this->assertSame($isFirstHalfOfYear, $d->isFirstHalfOfYear());
-        $this->assertSame($isSecondHalfOfYear, $d->isSecondHalfOfYear());
+        $this->assertSame($isFirstHalfOfYear, $d->isFirstHalf());
+        $this->assertSame($isSecondHalfOfYear, $d->isSecondHalf());
     }
 }
diff --git a/tests/TestCase/DateTime/IsTest.php b/tests/TestCase/DateTime/IsTest.php
@@ -458,7 +458,7 @@ public function testIsWithinNext()
     public function testIsFirstOrSecondHalfOfYear(int $month, bool $isFirstHalfOfYear, bool $isSecondHalfOfYear): void
     {
         $d = ChronosDate::create(2023, $month, 1);
-        $this->assertSame($isFirstHalfOfYear, $d->isFirstHalfOfYear());
-        $this->assertSame($isSecondHalfOfYear, $d->isSecondHalfOfYear());
+        $this->assertSame($isFirstHalfOfYear, $d->isFirstHalf());
+        $this->assertSame($isSecondHalfOfYear, $d->isSecondHalf());
     }
 }