Support creating Chronos from ChronosTime #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Sep 25, 2023
| { | ||
| $time = new ChronosTime('20:14:12.123456'); | ||
| $chronos = new Chronos($time); | ||
| $this->assertSame('20:14:12.123456', $chronos->format('H:i:s.u')); |
There was a problem hiding this comment.
Should we also have assertions for the date component of Chronos to help prevent regressions?
There was a problem hiding this comment.
It will always be the current date. I could check that?
There was a problem hiding this comment.
Should we special case using the test now date with a ChronosTime time or should it always be the current date?
There was a problem hiding this comment.
I think having a test that it is the current date would be good for future us.
There was a problem hiding this comment.
Extended tests to compare full Chronos string.
othercorey
force-pushed
the
chronos-from-chronostime
branch
from
e8340e3
to
a93a7ba
Compare
|
Looks good. I don't know what is up with psalm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.