Allow setting time zone when converting to DateTimeImmutable #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
commented
Sep 25, 2023
| @@ -176,9 +176,15 @@ public function testToW3cString() | |||
| public function testToDateTimeImmutable(): void | |||
| { | |||
| $d = ChronosDate::now(); | |||
| $this->assertSame($d->format('Y-m-d'), $d->toDateTimeImmutable()->format('Y-m-d')); | |||
| $this->assertSame($d->format('Y-m-d H:i:s.u'), $d->toDateTimeImmutable()->format('Y-m-d H:i:s.u')); | |||
There was a problem hiding this comment.
Extend the test to ensure the time isn't warped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to set the time zone when converting to DateTimeImmutable instead of only defaulting to the internal implementation.
Users will probably use this when converting between systems and will need flexibility.
This adds no extra overhead to the conversion.