[FIX] ci build and releases : Bump supported python versions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantodorovich
force-pushed
the
fix-ci
branch
4 times, most recently
from
91ac887 to
ea5445d
Compare
ivantodorovich
changed the title
ivantodorovich
force-pushed
the
fix-ci
branch
2 times, most recently
from
d7e4ef0 to
6d2a58c
Compare
Python 2.7 is no longer officially supported and it was removed from setup-python. actions/setup-python#672. Python 3.5 and 3.6 aren't really used neither, and CI is currently failing due to: ``` Version 3.5 was not found in the local cache Error: The version '3.5' with architecture 'x64' was not found for Ubuntu 22.04. ``` In any case, packages up to marabunta<=0.10.6 have been published and do support these deprecated python versions.
``` | lint: commands[0]> flake8 marabunta/ tests/ | tests/test_env_default.py:9:11: E275 missing whitespace after keyword | tests/test_env_default.py:15:11: E275 missing whitespace after keyword | tests/test_env_default.py:19:11: E275 missing whitespace after keyword | tests/test_env_default.py:23:11: E275 missing whitespace after keyword | tests/test_env_default.py:27:11: E275 missing whitespace after keyword | tests/test_env_default.py:31:11: E275 missing whitespace after keyword | tests/test_env_default.py:35:11: E275 missing whitespace after keyword | tests/test_env_default.py:39:11: E275 missing whitespace after keyword ```
Some other warnings (DeprecationWarning) were being logged and thus the `len` assertions failed. Using match is actually better for this purpose, as we only want to check if that particular warning is logged, doesn't matter if others are logged too.
ivantodorovich
force-pushed
the
fix-ci
branch
from
6d2a58c to
18c902d
Compare
simahawk
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #70 by bumping the supported python versions
Python 2.7 is no longer officially supported and it was removed from
setup-python. actions/setup-python#672.
Python 3.5 and 3.6 aren't really used neither, and CI is currently failing due
to:
In any case, packages up to marabunta<=0.10.6 have been published and do support
these deprecated python versions.
Ideally, this should be released in 0.11.0
The goal of this PR is to re-enable the publication to pypi, so we can install this package's latest version with
pip