Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] _find_manifest_path with directory less than 5 deep if no manifest found #73

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

petrus-v
Copy link
Contributor

This happens if the test module is less than 5 directories deep from root.

This happens if the test module is less than 5 directories
deep from root.
@petrus-v petrus-v mentioned this pull request Sep 24, 2024
@petrus-v
Copy link
Contributor Author

petrus-v commented Oct 3, 2024

hi @simahawk do you mind to activate the workflow in order to make sure test are running properly ?

I'm wondering why this project require maintainer approval to execute such test, do you worries about abuses or a missed configuration?

@petrus-v petrus-v mentioned this pull request Oct 3, 2024
@yvaucher
Copy link
Member

yvaucher commented Oct 4, 2024

For those tests I don't think we need to import Odoo as we it's quite heavy. Thus I have added a mock of the imported odoo modules here #75

@yvaucher
Copy link
Member

yvaucher commented Oct 5, 2024

Please rebase

#75 should now fix the CI

@yvaucher
Copy link
Member

yvaucher commented Oct 5, 2024

Tested locally, I'll rebase and merge

@yvaucher yvaucher merged commit c87b3f0 into camptocamp:master Oct 5, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants