Ensure filestore is shared when ran in a distributed way #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When test are ran in a distributed way, we must ensure that each worker has access to the original filestore even if they uses a copy of the original database. This is done by patching the the filestore method of the odoo configuration to point to the original filestore and avoid to copy the original filestore for each created database
lmignon
force-pushed
the
master-fix-distributed-filestore
branch
from
e3a6f6d to
36f1364
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage ? 33.05%
=========================================
Files ? 1
Lines ? 118
Branches ? 0
=========================================
Hits ? 39
Misses ? 79
Partials ? 0 ☔ View full report in Codecov by Sentry. |
sbidoul
reviewed
Oct 8, 2024
This will prevent error in case the db name is not compatible with the shell separators
yvaucher
approved these changes
Oct 8, 2024
|
good one ! thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test are ran in a distributed way, we must ensure that each worker has access to the original filestore even if they uses a copy of the original database. This is done by patching the the filestore method of the odoo configuration to point to the original filestore and avoid to copy the original filestore for each created database.
This PR also provides a fix for tests using HTTP controllers.