-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbon tutorial web components #4347
base: main
Are you sure you want to change the base?
Carbon tutorial web components #4347
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview link also wasn't working so I wasn't able to check that everything was rendering correctly.
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: andrew <emyarod@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
@ariellalgilmore updated plus a few comments. |
updates look great! one more thing i noticed when paginating on the table (might be a seperate issue though to open on cwc not sure). When moving to the next page the links jump to the stars column and the stars are gone |
Ah yes @ariellalgilmore fixed after pulls 17890 and 17895, just hadn't redeployed the tutorial preview. It would be really nice to be able to include #18034 or similar (Grid and Column component first pass). |
Closes #4289
Adds a Carbon tutorial using the same design as for the all the other framework tutorials.
Tutorial repository here https://github.com/carbon-design-system/carbon-tutorial-web-components
Changelog
New
NOTE 1: Issues to be resolved
NOTE 2: Issues to be addressed after #17895 and #17890 are released