Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon tutorial web components #4347

Open
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

lee-chase
Copy link
Member

@lee-chase lee-chase commented Oct 31, 2024

Closes #4289

Adds a Carbon tutorial using the same design as for the all the other framework tutorials.

Tutorial repository here https://github.com/carbon-design-system/carbon-tutorial-web-components

Changelog

New

  • src/pages/developing/web-components-tutorial folder and all contents

NOTE 1: Issues to be resolved

  • Currently uses React previews, really should show Web Component previews.
  • URL of gh-pages is a bit funky, may want to do something different solid-carnival-1pg38np.pages.github.io/
  • Support interim previous, can probably shoehorn this in to the existing repo, but we may want to publish elsewhere.

NOTE 2: Issues to be addressed after #17895 and #17890 are released

  • Pagination page size handler
  • Pagination page change handler
  • CDN versions

@lee-chase lee-chase requested review from a team as code owners October 31, 2024 14:43
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Nov 20, 2024 7:32pm

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview link also wasn't working so I wasn't able to check that everything was rendering correctly.

src/pages/developing/web-components-tutorial/overview.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-1.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-1.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-1.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-1.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-5.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-1.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-1.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-2.mdx Outdated Show resolved Hide resolved
src/pages/developing/web-components-tutorial/step-2.mdx Outdated Show resolved Hide resolved
lee-chase and others added 5 commits November 4, 2024 11:16
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
lee-chase and others added 12 commits November 19, 2024 09:54
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
lee-chase and others added 5 commits November 19, 2024 10:50
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Co-authored-by: andrew <emyarod@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
@lee-chase
Copy link
Member Author

@ariellalgilmore updated plus a few comments.

@ariellalgilmore
Copy link
Member

updates look great! one more thing i noticed when paginating on the table (might be a seperate issue though to open on cwc not sure). When moving to the next page the links jump to the stars column and the stars are gone
https://github.com/user-attachments/assets/c33d4570-205e-4684-90cb-79b54a44a626

@lee-chase
Copy link
Member Author

updates look great! one more thing i noticed when paginating on the table (might be a seperate issue though to open on cwc not sure). When moving to the next page the links jump to the stars column and the stars are gone https://github.com/user-attachments/assets/c33d4570-205e-4684-90cb-79b54a44a626

Ah yes @ariellalgilmore fixed after pulls 17890 and 17895, just hadn't redeployed the tutorial preview.

It would be really nice to be able to include #18034 or similar (Grid and Column component first pass).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tutorial for Carbon Web Components
7 participants