Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Update CardIO and CardIO-static build architectures to Standard. #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hadibadjian
Copy link

This is to avoid build issues using different SDKs (iphoneos and iphonesimulator).

This is to avoid build issues using different SDKs (iphoneos and iphonesimulator).
@bluk
Copy link
Contributor

bluk commented Apr 27, 2016

Can you be more specific about the build error that you encountered?

The reason why ARCHS_STANDARD isn't used is because we would lose the armv7s support out of the box. While A6(X) processors (iPhone 5/iPad 4) are probably an overall tiny minority and they should be able to use the armv7 generated code, some other dependent apps/libraries may encounter build trouble if armv7s is dropped by default. If anyone has thoughts around this, please leave a comment.

Also, we can probably just delete the lines from https://github.com/card-io/card.io-iOS-source/blob/master/build_configs/CardIO_Static_Library.xcconfig#L7 and https://github.com/card-io/card.io-iOS-source/blob/master/build_configs/CardIO_Framework.xcconfig#L7 .

@hadibadjian
Copy link
Author

I think the problem is the limitation of the supported architectures when the build is targeting the iPhone simulator SDK using the following build settings (in Debug build configuration):

    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
    PLATFORM_NAME = iphonesimulator
    SDKROOT = iphonesimulator9.2

I am trying to find a way that would not affect CardIO's supported architectures. I tried to modify the build config to build only for active architecture but no luck yet.

I will investigate more and update this Pull Request accordingly.

* 'master' of https://github.com/card-io/card.io-iOS-source:
  Ensure previewLayer is the right type depending on build
  Update `CardIOVideoStream`'s `previewLayer` to `CALayer` to allow it to be a `SimulatedCameraLayer`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants