Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0119 - Inconsistent field name #945

Open
palas opened this issue Dec 5, 2024 · 5 comments · May be fixed by #950
Open

CIP-0119 - Inconsistent field name #945

palas opened this issue Dec 5, 2024 · 5 comments · May be fixed by #950
Labels
Category: Metadata Proposals belonging to the 'Metadata' category.

Comments

@palas
Copy link

palas commented Dec 5, 2024

I've noticed when addressing this issue that while the schema calls this field "type", in this example it is written as "@type". We probably should make this consistent. And I imagine we should favour "@type" for consistency with CIP-0100
@rphair rphair added the Category: Metadata Proposals belonging to the 'Metadata' category. label Dec 5, 2024
@rphair
Copy link
Collaborator

rphair commented Dec 5, 2024

Thanks @palas - I can see the consistency. I don't work with related tooling so I'm tagging some reviewers & stakeholders to choose which term is canonical & agree upon a plan to change the other one. If there's no obvious choice about which is canonical, or uncertain implications in changing it, we'll put it up for discussion on Discord and/or the next CIP meeting.

cc @Thomas-Upfield @Ryun1 @gitmachtl @perturbing @Crypto2099 @Quantumplation

@gitmachtl
Copy link
Contributor

gitmachtl commented Dec 5, 2024 •
edited
Loading

@palas i agree. @type is one of the registered keywords for json-ld format. i am not sure if db-sync is checking on that too.

@rphair
Copy link
Collaborator

rphair commented Dec 5, 2024

@palas please confirm here if you'd like to submit a pull request standardising on @type in the schemas & we can likely put it through at or before the CIP meeting next week.

@palas
Copy link
Author

palas commented Dec 16, 2024

Sorry, I just saw the message. I am happy to make a PR to address this and also #949

@rphair
Copy link
Collaborator

rphair commented Dec 16, 2024

yes (and I also made #949 (comment) before seeing this), we appreciate the help @palas & I'll review and pass them along ASAP as soon as you submit the pull requests.

palas added a commit to palas/CIPs that referenced this issue Dec 16, 2024
@palas
Add "@" to the "@type" field of "reference" (address cardano-foundati…
2f6f5eb 
…on#945)
@palas palas linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Metadata Proposals belonging to the 'Metadata' category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CIP-0119 | Add "@" to the "@type" field of "references" palas/CIPs
3 participants
@palas @rphair @gitmachtl