CIP-0119 | Add "@" to the "@type" field of "references" #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
changed the title
rphair
changed the title
rphair
added
the
Category: Metadata
rphair
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
This looks complete from my (non-implementor) level but please @Ryun1 @Crypto2099 @perturbing post if there are lurking implications of this change.
Thanks @gitmachtl for confirming in #945 (comment) that this should be OK but also perhaps that db-sync is an application to watch out for.
rphair
added
Update
palas
changed the title
|
Great spot @palas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #945, by adding an
@symbol at the beginning of name of the@typefield of thereferencesfield ofCIP-0119, updating it in the JSON schema and the README.md.Fixes #945.